[SPARK-40424][CORE][TESTS] Refactor ChromeUIHistoryServerSuite to add UTs for RocksDB#37878
Closed
LuciferYang wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-40424][CORE][TESTS] Refactor ChromeUIHistoryServerSuite to add UTs for RocksDB#37878LuciferYang wants to merge 3 commits intoapache:masterfrom
ChromeUIHistoryServerSuite to add UTs for RocksDB#37878LuciferYang wants to merge 3 commits intoapache:masterfrom
Conversation
Member
|
cc @sarutak FYI |
Contributor
Author
|
rebased and updated pr description |
Contributor
Author
|
also cc @dongjoon-hyun due to the new test is for RocksDB |
Contributor
Author
|
friendly ping @sarutak |
| } | ||
|
|
||
| @ChromeUITest | ||
| class RocksBackendChromeUIHistoryServerSuite extends ChromeUIHistoryServerSuite { |
Member
There was a problem hiding this comment.
RocksBackendChromeUIHistoryServerSuite -> RocksDBBackendChromeUIHistoryServerSuite
Member
There was a problem hiding this comment.
Sorry for being late. Could you rename the test suite class, @LuciferYang ?
- RocksBackendChromeUIHistoryServerSuite
+ RocksDBBackendChromeUIHistoryServerSuite
dongjoon-hyun
approved these changes
Sep 19, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. I tested this test-only PR manually. Merged to master.
$ build/sbt -Dguava.version=31.1-jre -Dspark.test.webdriver.chrome.driver=/opt/homebrew/bin/chromedriver -Dtest.default.exclude.tags="" "core/testOnly org.apache.spark.deploy.history.RocksDBBackendChromeUIHistoryServerSuite"
...
[info] RocksDBBackendChromeUIHistoryServerSuite:
Starting ChromeDriver 105.0.5195.52 (412c95e518836d8a7d97250d62b29c2ae6a26a85-refs/branch-heads/5195@{#853}) on port 64391
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
[info] - ajax rendered relative links are prefixed with uiRoot (spark.ui.proxyBase) (1 second, 736 milliseconds)
[info] Run completed in 4 seconds, 924 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 12 s, completed Sep 18, 2022, 6:28:18 PM
Member
|
Thank you, @LuciferYang and @HyukjinKwon . |
Contributor
Author
Thanks for your help @dongjoon-hyun ~ |
LuciferYang
added a commit
to LuciferYang/spark
that referenced
this pull request
Sep 20, 2022
…dd UTs for RocksDB
### What changes were proposed in this pull request?
`ChromeUIHistoryServerSuite` only test LevelDB backend now, this pr refactor the UTs of `ChromeUIHistoryServerSuite` to add UTs for RocksDB
### Why are the changes needed?
Add UTs related to RocksDB.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- Pass GA
- Manual test on Apple Silicon environment：
```
build/sbt -Dguava.version=31.1-jre -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest.default.exclude.tags="" "core/testOnly org.apache.spark.deploy.history.RocksBackendChromeUIHistoryServerSuite"
```
```
[info] RocksBackendChromeUIHistoryServerSuite:
Starting ChromeDriver 105.0.5195.52 (412c95e518836d8a7d97250d62b29c2ae6a26a85-refs/branch-heads/5195{apache#853}) on port 54402
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
[info] - ajax rendered relative links are prefixed with uiRoot (spark.ui.proxyBase) (5 seconds, 387 milliseconds)
[info] Run completed in 20 seconds, 838 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 118 s (01:58), completed 2022-9-15 10:30:53
```
Closes apache#37878 from LuciferYang/SPARK-40424.
Lead-authored-by: yangjie01 <yangjie01@baidu.com>
Co-authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ChromeUIHistoryServerSuiteonly test LevelDB backend now, this pr refactor the UTs ofChromeUIHistoryServerSuiteto add UTs for RocksDBWhy are the changes needed?
Add UTs related to RocksDB.
Does this PR introduce any user-facing change?
No.
How was this patch tested?